fix(android): resolve APK installation failure on Android 16 - #183
Conversation
This commit addresses the "Attempt to get length of null array" error during APK installation on Android 16 (API 36) by broadening the .NET 10 native asset misclassification fix in osu.Android.props to include ResolvedFileToPublish. Additionally: - Updates PatchElfPageSize.targets to ensure local libraries in osu.Android/libs/ are patched to 16KB page alignment. - Enables default debug signing for "unsigned" workflow builds to ensure generated APKs are installable on modern devices while still being distinct from production-signed builds.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR resolves the
INSTALL_PARSE_FAILED_NO_CERTIFICATESerror (specifically the "Attempt to get length of null array" parsing failure) encountered when installing APKs on Android 16 (API 36).Changes:
FixRuntimePackAssetTypestarget inosu.Android.propsto includeResolvedFileToPublish. This ensures that native libraries (like BASS or local.sofiles) are correctly classified asnativerather than managed assemblies, which prevents the package manager from crashing during certificate collection.build/PatchElfPageSize.targetsto automatically patch native libraries found inosu.Android/libs/. Android 16 enforces 16KB page alignment for all 64-bit ELF LOAD segments; this change ensures our custom native libraries satisfy this requirement..github/workflows/release.ymlto remove the explicit disabling of the Android KeyStore for "unsigned" builds. This allows the .NET SDK to fall back to its default debug certificate, ensuring that the generated APK is signed and installable on modern devices while still being distinguished from production-signed releases.Verified that the modified logic correctly targets native assets and that the core project build remains stable.
PR created automatically by Jules for task 18130573469748600972 started by @winnerspiros